这是indexloc提供的服务,不要输入任何密码
Skip to content

chore(scm): gate manual file hash behind git2 #10088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

chris-olszewski
Copy link
Member

Description

We're getting some dead code warning when building @turbo/repository:

warning: function `git_like_hash_file` is never used
Warning:   --> crates/turborepo-scm/src/manual.rs:12:4
   |
12 | fn git_like_hash_file(path: &AbsoluteSystemPath) -> Result<String, Error> {
   |    ^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

warning: function `to_glob` is never used
Warning:   --> crates/turborepo-scm/src/manual.rs:31:4
   |
31 | fn to_glob(input: &str) -> Result<Glob, Error> {
   |    ^^^^^^^

warning: function `hash_files` is never used
Warning:   --> crates/turborepo-scm/src/manual.rs:38:15
   |
38 | pub(crate) fn hash_files(
   |               ^^^^^^^^^^

warning: function `get_package_file_hashes_without_git` is never used
Warning:   --> crates/turborepo-scm/src/manual.rs:59:15
   |
59 | pub(crate) fn get_package_file_hashes_without_git<S: AsRef<str>>(

Gate this module behind git2 to silence it.

Testing Instructions

cargo build -p turborepo-napi should not produce any errors

@chris-olszewski chris-olszewski requested a review from a team as a code owner March 4, 2025 21:42
Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:42pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:42pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:42pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:42pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:42pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:42pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:42pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:42pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:42pm

@chris-olszewski chris-olszewski merged commit f852d75 into main Mar 5, 2025
39 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/chore_silence_dead_code_scm branch March 5, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants