这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: correctly forward passthrough arguments when using pkg#task format #10087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2025
Merged

fix: correctly forward passthrough arguments when using pkg#task format #10087

merged 2 commits into from
Mar 5, 2025

Conversation

@NicholasLYang
Copy link
Contributor

@NicholasLYang NicholasLYang commented Mar 4, 2025 •
edited
Loading

Description

Closes #10086. Parses the task as a TaskName before checking if task matches for passthrough args, to account for tasks being passed pkg#task.

Testing Instructions

Added a test for passthrough args

@vercel
Copy link
Contributor

vercel bot commented Mar 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 8:35pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 8:35pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 8:35pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 8:35pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 8:35pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 8:35pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 8:35pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 8:35pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 8:35pm

@NicholasLYang NicholasLYang force-pushed the nicholasyang/fix-args-forwarding branch from 179677d to 3172e8f Compare March 4, 2025 20:49
@NicholasLYang NicholasLYang force-pushed the nicholasyang/fix-args-forwarding branch from 3172e8f to 4732ceb Compare March 4, 2025 21:16
@NicholasLYang NicholasLYang marked this pull request as ready for review March 4, 2025 21:18
@NicholasLYang NicholasLYang force-pushed the nicholasyang/fix-args-forwarding branch from af5dc48 to 982d812 Compare March 5, 2025 18:28
@NicholasLYang NicholasLYang force-pushed the nicholasyang/fix-args-forwarding branch from 982d812 to c4b2971 Compare March 5, 2025 20:34
@NicholasLYang NicholasLYang merged commit b369e8e into main Mar 5, 2025
39 checks passed
@NicholasLYang NicholasLYang deleted the nicholasyang/fix-args-forwarding branch March 5, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

@dimitropoulos dimitropoulos Awaiting requested review from dimitropoulos dimitropoulos is a code owner automatically assigned from vercel/turbo-oss

1 more reviewer

@chris-olszewski chris-olszewski chris-olszewski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't pass arguments to the underlying command when using #

3 participants

@NicholasLYang @chris-olszewski