-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(boundaries): support import attributes #10078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
34017c1 to
244e55c
Compare
anthonyshew
approved these changes
Mar 3, 2025
1 task
anthonyshew
added a commit
that referenced
this pull request
Nov 5, 2025
Enables parsing of import attributes (the `with` keyword syntax) in the boundaries command by setting `import_attributes: true` in the SWC parser configuration. This was previously fixed for turbo-trace in PR #10078 but was missing from the boundaries module, causing parse errors when encountering syntax like `import x from 'y' with { type: 'json' }`. Fixes #10961 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
3 tasks
anthonyshew
added a commit
that referenced
this pull request
Nov 5, 2025
## Summary Fixes #10961 - Enables parsing of import attributes (the `with` keyword syntax) in the `turbo boundaries` command. ## Details The issue was that PR #10078 fixed import attributes parsing for `turbo-trace` but didn't apply the same fix to the boundaries module. This caused the boundaries command to fail with "Expected ';', got 'with'" when encountering modern import syntax like: ```js import pkg from './package.json' with { type: 'json' }; ``` ## Changes - Added `import_attributes: true` to the SWC ES syntax configuration in `crates/turborepo-lib/src/boundaries/mod.rs:437` - Added test fixture with import attributes to verify the fix works ## Test Plan - [x] Built the project successfully - [x] Verified boundaries command now parses files with import attributes without errors - [x] Added test fixture file with import attributes that gets checked by integration tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support import attributes. Also bumps our prettier version so prettier can format import attributes.
Testing Instructions
Adds a test for them.