chore(turbo_json): remove exterior mutability from loader #10066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
NicholasLYang
approved these changes
Mar 3, 2025
Co-authored-by: Nicholas Yang <nicholas.yang@vercel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TurboJsonLoader::loadonly took a mutable self reference because we were usingHashMapto cache the results. This PR changes the data type we use to cache results and removes the exterior mutability.We move to use a
FixedMapwhich has the following properties:I went with this just because the implementation is straightforward and matches our use case since we know all of the possible places a
turbo.jsonwill be before we start loading them.Future work can be reworking boundaries code to no longer eagerly load all of the
turbo.jsons at the start of execution.Testing Instructions
Existing test suite. Additional unit tests for
FixedMap