这是indexloc提供的服务,不要输入任何密码
Skip to content

fix(engine): no longer error if provided task is omitted by filter #10051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

chris-olszewski
Copy link
Member

Description

Fixes #9619

This PR makes it so we no longer error if the filter excludes a task provided by the user. This is especially helpful when filters are not static such as --affected or SCM based filters.

Testing Instructions

Updated unit tests.

Before

# Task only defined on `@turbo/types`
[0 olszewski@macbookpro] /Users/olszewski/code/vercel/turborepo $ turbo copy-schema --filter=cli 
 WARNING  No locally installed `turbo` found. Using version: 2.4.4.
turbo 2.4.4

  × Missing tasks in project
  ╰─▶   × Could not find task `copy-schema` in project

# Task only defined at root

[1 olszewski@macbookpro] /Users/olszewski/code/vercel/turborepo $ turbo build check:toml --filter='!cli'
 WARNING  No locally installed `turbo` found. Using version: 2.4.4.
turbo 2.4.4

  × Missing tasks in project
  ╰─▶   × Could not find task `check:toml` in project

After

# Task only defined on `@turbo/types`
[0 olszewski@macbookpro] /Users/olszewski/code/vercel/turborepo $ turbo_dev copy-schema --filter=cli
 WARNING  No locally installed `turbo` found. Using version: 2.4.4.
turbo 2.4.4

• Packages in scope: cli
• Running copy-schema in 1 packages
• Remote caching enabled

No tasks were executed as part of this run.

 Tasks:    0 successful, 0 total
Cached:    0 cached, 0 total
  Time:    113ms 

# Task only defined at root
[0 olszewski@macbookpro] /Users/olszewski/code/vercel/turborepo $ turbo_dev check:toml --filter='!cli'
 WARNING  No locally installed `turbo` found. Using version: 2.4.4.
turbo 2.4.4

• Packages in scope: @turbo-internal/top-issues-gh-action, @turbo/benchmark, @turbo/codemod, @turbo/eslint-config, @turbo/exe-stub, @turbo/gen, @turbo/releaser, @turbo/telemetry, @turbo/test-utils, @turbo/tsconfig, @turbo/types, @turbo/utils, @turbo/workspaces, @turborepo-examples-tests/basic-npm, @turborepo-examples-tests/basic-pnpm, @turborepo-examples-tests/basic-yarn, @turborepo-examples-tests/kitchen-sink-npm, @turborepo-examples-tests/kitchen-sink-pnpm, @turborepo-examples-tests/kitchen-sink-yarn, @turborepo-examples-tests/non-monorepo-npm, @turborepo-examples-tests/non-monorepo-pnpm, @turborepo-examples-tests/non-monorepo-yarn, @turborepo-examples-tests/with-svelte-npm, @turborepo-examples-tests/with-svelte-pnpm, @turborepo-examples-tests/with-svelte-yarn, @turborepo-examples-tests/with-tailwind-npm, @turborepo-examples-tests/with-tailwind-pnpm, @turborepo-examples-tests/with-tailwind-yarn, cargo-sweep-action, create-turbo, eslint-config-turbo, eslint-plugin-turbo, prysk, turbo-ignore, turbo-vsc, turborepo-examples, turborepo-repository, turborepo-tests-helpers, turborepo-tests-integration
• Running check:toml in 39 packages
• Remote caching enabled

No tasks were executed as part of this run.

 Tasks:    0 successful, 0 total
Cached:    0 cached, 0 total
  Time:    123ms 


Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:13pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:13pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:13pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:13pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:13pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:13pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:13pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:13pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:13pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"missing tasks" when using root task + filters
2 participants