feat(boundaries): support tsconfig path aliases #10002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
f840124 to
5f837e5
Compare
5f837e5 to
3289c87
Compare
3289c87 to
7e49606
Compare
5b3c253 to
6468a37
Compare
chris-olszewski
approved these changes
Feb 26, 2025
Comment on lines
91
to
92
| pub type PackageKey = String; | ||
| pub type PackageVersion = String; |
There was a problem hiding this comment.
I don't like these type aliases, can we keep them contained to this crate?
There was a problem hiding this comment.
I didn't want to have the type be BTreeMap<String, String>, since that's sort of opaque. Should I just copy them over?
| if let Some(config) = self.configs.get(dir) { | ||
| return Some(config.clone()); | ||
| } | ||
| if let Ok(config) = self.resolver.resolve_tsconfig(dir) { |
There was a problem hiding this comment.
Maybe add debug log when we fail to resolve a ts config?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support tsconfig path aliases such as:
{ "compilerOptions": { "paths": { "@/*": ["./*"] } } }We check if we can resolve the import as a path alias and if so, check the resolved path
Can be reviewed commit by commit
Testing Instructions
Turns out we already had a test for this in
turborepo-tests/integration/fixtures/boundaries/apps/my-app/types.ts. Added another import and updated snapshot