fix(examples): correct 'test:projects' script to use vitest directly #10683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
@namidapoo is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
anthonyshew
requested changes
Jul 16, 2025
Contributor
anthonyshew
left a comment
There was a problem hiding this comment.
Hi, thanks for this. Can you remove the unrelated docs changes (the newline changes and dangling commas)?
The 'test:projects' script was incorrectly using "turbo run test" instead of "vitest run", which didn't match the intended behavior of using Vitest's projects feature directly.
b265d34 to
7e043c9
Compare
Contributor
Author
@anthonyshew Thanks for the feedback! |
anthonyshew
approved these changes
Jul 17, 2025
Contributor
anthonyshew
left a comment
There was a problem hiding this comment.
Thanks, let's merge!
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the
test:projectsscript in thewith-vitestexample to use Vitest's projects feature directly.Currently, the
test:projectsscript runsturbo run test, which leverages Turborepo's package-level caching. However, given the script name and the example's hybrid approach documentation, it seems more appropriate for this command to usevitest rundirectly to demonstrate Vitest's projects feature.Changes made:
package.jsonto usevitest runfor thetest:projectsscripttest:projectsdoesdocs/site/content/docs/guides/tools/vitest.mdxto reflect the correct usageTesting Instructions
examples/with-vitestdirectorypnpm installpnpm --filter @repo/vitest-config buildpnpm test- Should run tests using Turborepo (with caching)pnpm test:projects- Should run tests using Vitest's projects feature directlypnpm test:projects:watch- Should run tests in watch mode using Vitest's projects featuretestandtest:projectsnow have different behaviors as intended