chore(tower-uds): delete unused crate #10676
Merged
+0
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
requested changes
Jul 15, 2025
crates/tower-uds/Cargo.toml
Outdated
| @@ -7,7 +7,7 @@ license = "MPL-2.0" | |||
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | |||
|
|
|||
| [dependencies] | |||
| tokio = { workspace = true, features = ["net"] } | |||
| tokio = { workspace = true, features = ["net", "macros", "rt", "io-util"] } | |||
There was a problem hiding this comment.
Are these required? I'm a little concerned about adding these features just for testing since they're invasive and will end up in the binary.
There was a problem hiding this comment.
Ah, you right. I moved them to dev-dependencies. Is that sufficient?
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
3490ced to
c0916cd
Compare
chris-olszewski
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.