这是indexloc提供的服务,不要输入任何密码
Skip to content

fix(examples): update vitest config paths for packages and apps in with-vitest #10675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

kenfdev
Copy link
Contributor

@kenfdev kenfdev commented Jul 14, 2025

Description

The current --with-vitest example's root vitest.config.ts has * in the paths which seems to be invalid as shown below:

The project root contains the "*" character (/workspace/tmp/my-turborepo/packages/*), which may not work when running Vite. Consider renaming the directory / file to remove the characters.
The project root contains the "*" character (/workspace/tmp/my-turborepo/apps/*), which may not work when running Vite. Consider renaming the directory / file to remove the characters.

 DEV  v3.2.4 /workspace/tmp/my-turborepo

No test files found. You can change the file name pattern by pressing "p"


 0  

include: **/*.{test,spec}.?(c|m)[jt]s?(x)
exclude:  **/node_modules/**, **/dist/**, **/cypress/**, **/.{idea,git,cache,output,temp}/**, **/{karma,rollup,webpack,vite,vitest,jest,ava,babel,nyc,cypress,tsup,build,eslint,prettier}.config.*

 1  

include: **/*.{test,spec}.?(c|m)[jt]s?(x)
exclude:  **/node_modules/**, **/dist/**, **/cypress/**, **/.{idea,git,cache,output,temp}/**, **/{karma,rollup,webpack,vite,vitest,jest,ava,babel,nyc,cypress,tsup,build,eslint,prettier}.config.*

Removing /* sufix fixes this issue as show below:

› bun run test:projects:watch
$ vitest --watch

 DEV  v3.2.4 /workspace/tmp/my-turborepo

 ✓  0  math/tests/math.test.ts (2 tests) 2ms
 ✓  1  web/tests/math.test.ts (1 test) 1ms
 ✓  1  docs/tests/math.test.ts (1 test) 1ms

 Test Files  3 passed (3)
      Tests  4 passed (4)
   Start at  07:11:36
   Duration  515ms (transform 43ms, setup 0ms, collect 31ms, tests 4ms, environment 626ms, prepare 139ms)

This is related to #10659 (comment)

Testing Instructions

Just run:

bun run test:projects:watch

@kenfdev kenfdev requested a review from a team as a code owner July 14, 2025 22:14
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage labels Jul 14, 2025
Copy link

vercel bot commented Jul 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 10:15pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 10:15pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 10:15pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 10:15pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 10:15pm

Copy link

vercel bot commented Jul 14, 2025

@kenfdev is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@anthonyshew anthonyshew merged commit 7f11487 into vercel:main Jul 15, 2025
8 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants