feat(auth): optional callback port #10666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 3 new tests to increase coverage from 87.50% to 90.57%: - test_close_with_timeout: Tests the close_with_timeout method - test_client_error_handling: Tests error handling when client fails - test_add_session_id: Tests the add_session_id utility function These tests cover previously untested code paths including timeout handling, error scenarios, and utility functions.
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some situations, users might want to change the port for the callback when logging in. This PR allows such behavior through an ` environment variable.
Testing Instructions
I manually tested that the port changes in the URL. Also added some tests.