这是indexloc提供的服务，不要输入任何密码
Skip to content

refactor(examples): update CSS variable names to use consistent --color- prefix in tailwind examples #10662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

refactor(examples): update CSS variable names to use consistent --color- prefix in tailwind examples #10662

merged 1 commit into from
Jul 14, 2025

Conversation

@eric-hjh
Copy link
Contributor

@eric-hjh eric-hjh commented Jul 13, 2025

Description

Tailwind CSS v4 uses the --color-* convention for custom properties.

In the current example file at
examples/with-tailwind/packages/tailwind-config/shared-styles.css,
the custom color variables do not use the --color- prefix, which causes them not to work correctly with Tailwind v4.

This PR updates the variable names to follow the correct naming convention, allowing them to be used properly with Tailwind's color system.

Before:

@theme {
  --blue-1000: #2a8af6;
  --purple-1000: #a853ba;
  --red-1000: #e92a67;
}

After:

@theme {
  --color-blue-1000: #2a8af6;
  --color-purple-1000: #a853ba;
  --color-red-1000: #e92a67;
}

@eric-hjh eric-hjh requested a review from a team as a code owner July 13, 2025 09:29
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples needs: triage labels Jul 13, 2025
@vercel
Copy link
Contributor

vercel bot commented Jul 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2025 9:29am
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2025 9:29am
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2025 9:29am
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2025 9:29am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2025 9:29am

@vercel
Copy link
Contributor

vercel bot commented Jul 13, 2025

@eric-hjh is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

anthonyshew
anthonyshew approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anthonyshew anthonyshew merged commit 40dff7b into vercel:main Jul 14, 2025
28 of 33 checks passed
@renovate renovate bot mentioned this pull request Aug 3, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anthonyshew anthonyshew anthonyshew approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski is a code owner automatically assigned from vercel/turbo-oss

Assignees

No one assigned

Labels

area: examples Improvements or additions to examples

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eric-hjh @anthonyshew