test(turborepo-analytics): improve unit test coverage #10651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 3 new tests to increase coverage from 87.50% to 90.57%: - test_close_with_timeout: Tests the close_with_timeout method - test_client_error_handling: Tests error handling when client fails - test_add_session_id: Tests the add_session_id utility function These tests cover previously untested code paths including timeout handling, error scenarios, and utility functions.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
approved these changes
Jul 14, 2025
Comment on lines
385
to
416
| #[tokio::test] | ||
| async fn test_close_with_timeout() { | ||
| let (tx, _rx) = mpsc::unbounded_channel(); | ||
|
|
||
| let client = DummyClient { | ||
| events: Default::default(), | ||
| tx, | ||
| }; | ||
|
|
||
| let (analytics_sender, analytics_handle) = start_analytics( | ||
| APIAuth { | ||
| token: "foo".to_string(), | ||
| team_id: Some("bar".to_string()), | ||
| team_slug: None, | ||
| }, | ||
| client.clone(), | ||
| ); | ||
|
|
||
| // Send an event | ||
| analytics_sender | ||
| .send(AnalyticsEvent { | ||
| session_id: None, | ||
| source: CacheSource::Local, | ||
| event: CacheEvent::Hit, | ||
| hash: "".to_string(), | ||
| duration: 0, | ||
| }) | ||
| .unwrap(); | ||
|
|
||
| // Test close_with_timeout - should not panic | ||
| analytics_handle.close_with_timeout().await; | ||
| } |
There was a problem hiding this comment.
We can drop this test, I'm not sure what this tests that other ones don't already.
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves test coverage for from 87.50% to 90.57% (+3.07%) in
turobrepo-analytics.Changes
Added 3 new tests to cover previously untested code paths:
Coverage Impact
All tests pass and cover important error handling and utility function scenarios.