这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(turborepo-vt100): prevent panic in col_wrap when drawing_row_mut returns None #10640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(turborepo-vt100): prevent panic in col_wrap when drawing_row_mut returns None #10640

wants to merge 1 commit into from

Conversation

@anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Jul 5, 2025 •
edited
Loading

Summary

  • Replace dangerous unwrap() with safe error handling in Grid::col_wrap method
  • Add comprehensive unit tests to verify the fix and prevent regressions

Test plan

  • Added unit tests that specifically target the edge case where drawing_row_mut returns None
  • Verified all existing tests continue to pass
  • Tests confirm no panics occur in edge cases involving terminal scrolling and wrapping

@anthonyshew
fix(turborepo-vt100): prevent panic in col_wrap when drawing_row_mut …
e1aa29e 
…returns None

Replace unwrap() with safe error handling in Grid::col_wrap to prevent
potential panics when drawing_row_mut(prev_pos.row) returns None.

🤖 Generated with [opencode](https://opencode.ai)

Co-Authored-By: opencode <noreply@opencode.ai>
@anthonyshew anthonyshew requested a review from a team as a code owner July 5, 2025 15:33
@vercel
Copy link
Contributor

vercel bot commented Jul 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2025 3:36pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2025 3:36pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2025 3:36pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2025 3:36pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2025 3:36pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2025 3:36pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2025 3:36pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2025 3:36pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2025 3:36pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2025 3:36pm

@anthonyshew anthonyshew linked an issue Jul 5, 2025 that may be closed by this pull request
Crash related to TUI column rendering #10639
Open
1 task
@anthonyshew
Copy link
Contributor Author

anthonyshew commented Jul 7, 2025

This PR was part of an experiment I was doing to test how fast we could reliably go in the repo with LLMs. We've seen enough PRs we don't like come through that we think could be improved by first circling back to improve the health of the codebase. As a first step, we're going to be investing in test coverage.

Closing this PR with these interests in mind.

@anthonyshew anthonyshew closed this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski is a code owner automatically assigned from vercel/turbo-oss

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash related to TUI column rendering

2 participants

@anthonyshew