-
Notifications
You must be signed in to change notification settings - Fork 2k
docs: clarify default inputs behavior #10628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @anthonyshew, couple of minor comments
@@ -419,7 +419,7 @@ Defines if task outputs should be cached. Setting `cache` to false is useful for | |||
|
|||
Default: `[]`, all files in the package that are checked into source control | |||
|
|||
A list of file glob patterns relative to the package's `package.json` to consider when determining if a package has changed. `turbo.json` is **always** considered an input. | |||
A list of file glob patterns relative to the package's `package.json` to consider when determining if a package has changed. `turbo.json` and `package.json` are **always** considered inputs, even if you try to explicitly ignore them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Are there any other exceptions worth listing, lockfiles maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chris-olszewski, I actually don't know this one. Can I ignore a lockfile? I'm figuring I can't since we go parse it separately from collecting file inputs.
I shouldn't be able to, but can I? I'm trying to see if I can trick it into doing so and it doesn't look like it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we'll always parse the lockfile and fold the packages into a task hash.
Co-authored-by: Brad Adams <hi@breadadams.com>
Description
#10606 pointed out a minor clarification that we needed about
inputs
.