refactor: add spans to some turbo.json fields #10627
Merged
+101
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
approved these changes
Jul 3, 2025
| @@ -116,7 +116,15 @@ impl WithMetadata for RawTurboJson { | |||
|
|
|||
| self.tasks.add_text(text.clone()); | |||
| self.cache_dir.add_text(text.clone()); | |||
| self.pipeline.add_text(text); | |||
| self.pipeline.add_text(text.clone()); | |||
There was a problem hiding this comment.
Might be able to skip pipeline
There was a problem hiding this comment.
I'm thinking I'm going to leave it for the sake of consistency - unless there's some perf or other upside I'm not realizing. The consternation I experienced when I went to work with these and some had spans and some didn't... :old-man-yells-at-unexpected-things:
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
anthonyshew
commented
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-work for #10610. Not all of our fields have spans, so we need to add them to get better at doing error reporting in some situations.