refactor: consolidate configuration file resolving #10619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: anthony.shew <anthony.shew@vercel.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anthonyshew
commented
Jul 1, 2025
anthonyshew
commented
Jul 1, 2025
…sing Co-authored-by: anthony.shew <anthony.shew@vercel.com>
Co-authored-by: anthony.shew <anthony.shew@vercel.com>
anthonyshew
commented
Jul 1, 2025
chris-olszewski
approved these changes
Jul 7, 2025
Contributor
chris-olszewski
left a comment
There was a problem hiding this comment.
Fix lints, but otherwise LGTM
anthonyshew
added a commit
that referenced
this pull request
Jul 15, 2025
### Description #10619 put this logic in a shared place, but looks like I missed this spot. ### Testing Instructions This should be a pure refactor, so CI should catch regressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the codebase to deduplicate the logic for resolving
turbo.jsonandturbo.jsoncconfiguration files.resolve_turbo_config_pathin Rust (crates/turborepo-lib/src/turbo_json/mod.rs) andresolveTurboConfigPathin TypeScript (packages/turbo-utils/src/getTurboConfigs.ts).turbo.jsonandturbo.jsonc(precedence, error on both existing) remains unchanged.Testing Instructions
cargo testin the Rust workspace.pnpm check-typesin the root to verify TypeScript changes.