这是indexloc提供的服务，不要输入任何密码
Skip to content

refactor(examples): remove duplicate Next.js plugin from app tsconfig files #10612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

refactor(examples): remove duplicate Next.js plugin from app tsconfig files #10612

merged 1 commit into from
Jul 1, 2025

Conversation

@JeongHwan-dev
Copy link
Contributor

@JeongHwan-dev JeongHwan-dev commented Jun 30, 2025 •
edited
Loading

Description

Removes duplicate Next.js TypeScript plugin configuration from examples/with-nestjs/apps/web/tsconfig.json.

The "next" plugin was configured in two places:

  • ✅ packages/typescript-config/nextjs.json (shared config)
  • ❌ apps/web/tsconfig.json (duplicate)

Since the app already extends the shared config, the duplicate plugin definition is unnecessary.

File: examples/with-nestjs/apps/web/tsconfig.json

Removed:

"compilerOptions": {
  "plugins": [
    {
      "name": "next"
    }
  ]
}

The plugin is already inherited from @repo/typescript-config/nextjs.json.

@JeongHwan-dev JeongHwan-dev requested a review from a team as a code owner June 30, 2025 12:24
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples needs: triage labels Jun 30, 2025
@vercel
Copy link
Contributor

vercel bot commented Jun 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2025 0:24am
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2025 0:24am
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2025 0:24am
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2025 0:24am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2025 0:24am

@vercel
Copy link
Contributor

vercel bot commented Jun 30, 2025

@JeongHwan-dev is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

anthonyshew
anthonyshew approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anthonyshew anthonyshew enabled auto-merge (squash) July 1, 2025 01:58
@anthonyshew anthonyshew merged commit 4630c45 into vercel:main Jul 1, 2025
29 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anthonyshew anthonyshew anthonyshew approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski is a code owner automatically assigned from vercel/turbo-oss

Assignees

No one assigned

Labels

area: examples Improvements or additions to examples

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JeongHwan-dev @anthonyshew