ci: ensure turbo-types schemas are in sync #10609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
approved these changes
Jun 29, 2025
.github/workflows/turborepo-test.yml
Outdated
Comment on lines
237
to
240
| - name: Setup Turborepo Environment | ||
| uses: ./.github/actions/setup-turborepo-environment | ||
| with: | ||
| github-token: "${{ secrets.GITHUB_TOKEN }}" |
There was a problem hiding this comment.
This might be a little heavy. I think we could get away with just setting up Node. This action installs Rust/Protobuf/Capnp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #10590, I edited the JSON schema directly, which isn't the right way.
This PR introduces a CI check that I (and others) can't make this sort of mistake in the future.
Testing Instructions
This commit shows a failure because I added a
testkey to the schema (and malformatted it in the process).