chore: update to Rust 1.88.0 #10608
Merged
chore: update to Rust 1.88.0 #10608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
@ognevny is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
f0ad624 to
31c73f7
Compare
Contributor
Author
|
@chris-olszewski can you have a look into it, please? |
3bb79f7 to
2a9fb7e
Compare
bb09784 to
d8bb191
Compare
chris-olszewski
approved these changes
Jul 21, 2025
| let mut previous_char: Option<char> = None; | ||
|
|
||
| for (i, char) in pattern.chars().enumerate() { | ||
| for (i, char) in pattern.char_indices() { |
Contributor
There was a problem hiding this comment.
This is a behavior change if characters take up multiple bytes, but we already would panic on those strings. I think this will just break in a slightly different way which is okay.
Actually fixing this code can/should be fixed in it's own PR.
Contributor
|
Apologies for slow review. Thank you for keeping us current! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
std::hash::Hasher::hashis no longer detects as trait method. I removed its reference to fix tons of warningsformat!(and some more) args: https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_argschar_indiceswhere applicable: https://rust-lang.github.io/rust-clippy/master/index.html#char_indices_as_byte_indices (possibly introduces regressions)Testing Instructions
CI