这是indexloc提供的服务,不要输入任何密码
Skip to content

fix(example): add missing Tailwind import to shared ui styles #10579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

sahyl
Copy link
Contributor

@sahyl sahyl commented Jun 18, 2025

This PR fixes vercel/turborepo#10566 by adding the missing Tailwind import to shared-styles.css in the packages/ui directory of the with-tailwind example.

What was the problem?

Shared components like Card or Button had Tailwind classes, but styles were not applied because Tailwind layers were never included.

Screenshot 2025-06-18 165631

What changed?

Added:

@import "tailwindcss";

to packages/ui/shared-styles.css.

Result

Screenshot 2025-06-18 165704

Tested locally using:

pnpm install
pnpm dev --filter=with-tailwind

UI components are now styled correctly.

Closes #10566

@sahyl sahyl requested a review from a team as a code owner June 18, 2025 11:18
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage labels Jun 18, 2025
Copy link

vercel bot commented Jun 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2025 11:19am
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2025 11:19am
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2025 11:19am
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2025 11:19am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2025 11:19am

Copy link

vercel bot commented Jun 18, 2025

@sahyl is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@sahyl
Copy link
Contributor Author

sahyl commented Jun 18, 2025

Hi! This is my first contribution — happy to improve anything if needed. Thanks for taking a look 🙏

@BennettDixon
Copy link

BennettDixon commented Jun 18, 2025

+1 encountering this issue after setting up from the example; this fix works for me.

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anthonyshew anthonyshew merged commit e2bf0b0 into vercel:main Jun 19, 2025
28 of 33 checks passed
sahyl added a commit to sahyl/turborepo-style-fix that referenced this pull request Jun 19, 2025
@sahyl
Copy link
Contributor Author

sahyl commented Jun 19, 2025

My first PR — fun learning experience. Appreciate the review and merge! excited to contribute more soon 🙌

@sahyl sahyl deleted the fix/shared-ui-tailwind-import branch June 19, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TailwindCSS Styles Don't Apply to NextJS App on Example Repo with-tailwind
3 participants