fix(pnpm): respect deep for linkWorkspacePackages #10558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tknickman
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #10528
With #10391 we started reading
linkWorkspacePackagesfrompnpm-workspace.yaml. This caused issues with single package vs monorepo detection asdeepis a valid value here and we only expected a boolean. This would cause a detection of a single package repo and we would swallow the error ofpnpm-workspace.yamlnot parsing due to the usage ofdeep.This PR adds support for
deepon the parsing endFollow up PR is to have noisy warnings if we find a
pnpm-workspace.yaml, but do not understand it.Testing Instructions
Added a red/green test. Verified with https://github.com/ocavue/starter-monorepo