With dockerfile update #10550
Open
With dockerfile update #10550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng for old dockerfiles
…ng for old dockerfiles
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
@kessenma is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
1 task
Contributor
|
I'm trying to use this with pnpm and running into many issues. Can you try it out and fix those? Thank you. |
Author
|
Ok I'll look into it some more with a fresh install and pnpm. I'll also update the testing steps above so they're written with better testing steps. I'll comment back here when I'm done. |
Contributor
|
@kessenma Would you still like to work on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in the readme.md
Description
added in support for using npm, pnpm, and yarn dockerfiles via a use-dockerfile.js script. directions are in the readme.md
Testing Instructions
Give a quick description of steps to test your changes.
1 run the following scripts from the turborepo/examples/with-docker/package.json:
use-pnpm-dockerfileuse-pnpm-dockerfileuse-pnpm-dockerfile2 check that the with-docker/package.json and see if the "packageManager" (line 27) was updated to match pnpm/npm/yarn
3 check that the dockerfiles inside the project are now configured with pnpm/npm/yarn
4 ensure that the old Dockerfile's were archived in these folders:
turborepo/examples/with-docker/apps/api/archived-docker-file
turborepo/examples/with-docker/apps/web/archived-dockerfile