-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(bun): fix workspace peerDependencies #10549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@camero2734 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
chris-olszewski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break some analysis since peerDependencies are not actually provided by the package they are declared in. The host package needs to include them. Maybe this isn't the case for Bun, but if so we need to make this behavior package manager dependent.
|
Are there any plans to find a way to resolve this? I know a lot of people would love to be able to fully use turbo prune with bun 😄 |
|
I'll close this one because Bun has changed their lockfile format entirely. We're working on the new version in #10729. Let's meet up there! |
Description
Should resolve #10410
Both Bun and NPM install (non-optional) peer dependencies by default in their latest versions. It seems turbo currently skips over peerDependencies when calculating
all_packagesfor apackage.json, which results in (at least for Bun) an incomplete lockfile since "unmet" peer dependencies aren't resolved.Testing Instructions
Utilizing the repro repo provided in #10410 (comment):
Before:
bunx turbo prune @pkg/a --docker cd out/json bun install --frozen-lockfilegives
After:
../turborepo/target/debug/turbo prune @pkg/a --docker --skip-infer cd out/json bun install --frozen-lockfilegives no error