这是indexloc提供的服务,不要输入任何密码
Skip to content

docs: account for Custom Environments #10515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

docs: account for Custom Environments #10515

merged 2 commits into from
May 28, 2025

Conversation

anthonyshew
Copy link
Contributor

Description

Our script allowed for a custom environment to write to production. Instead, we make sure only the VERCEL_TARGET_ENV that is "production" can do so.

@anthonyshew anthonyshew requested a review from a team as a code owner May 28, 2025 11:28
Copy link

vercel bot commented May 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 1:01pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 1:01pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 1:01pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 1:01pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 1:01pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 1:01pm
examples-svelte-web ❌ Failed (Inspect) May 28, 2025 1:01pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 1:01pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 1:01pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 1:01pm

Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is effective as it still lets us write non-production domains to the production index.

@anthonyshew
Copy link
Contributor Author

🤦 Of course. Added another line to throw when that's the case.

@anthonyshew anthonyshew merged commit c0c234f into main May 28, 2025
34 of 35 checks passed
@anthonyshew anthonyshew deleted the shew/68951 branch May 28, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants