这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented May 29, 2025

Description

The with-svelte example deploys in our CI have been broken. This PR gets them back to green.

Testing Instructions

CI

@anthonyshew anthonyshew requested a review from a team as a code owner May 29, 2025 02:23
@turbo-orchestrator turbo-orchestrator bot added the area: examples Improvements or additions to examples label May 29, 2025
@vercel
Copy link
Contributor

vercel bot commented May 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 3:57pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 3:57pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 3:57pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 3:57pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 3:57pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 3:57pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 3:57pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 3:57pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 3:57pm
examples-with-svelte-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 3:57pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
turbo-site ⬜️ Skipped (Inspect) May 30, 2025 3:57pm

@anthonyshew anthonyshew changed the title fix: with-svelte example builds" fix: with-svelte example builds May 29, 2025
Copy link
Contributor

@melroy89 melroy89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I could approve the PR. I would have 😅.

Although deployments still fails?

@anthonyshew
Copy link
Contributor Author

@melroy89 Yes, I'm still trying to sort out what the issue is.

chris-olszewski added a commit that referenced this pull request May 30, 2025
### Description

If a task needs to access the pnpm store during execution and it is in a
different spot than the default, it will be unable to find it.

### Testing Instructions

Merge + release. Then `with-svelte` example should start passing. Should
remove need for #10517
@anthonyshew anthonyshew merged commit 80f5219 into main May 30, 2025
33 checks passed
@anthonyshew anthonyshew deleted the shew/d07d7 branch May 30, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: examples Improvements or additions to examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants