feat: add Workspace.find_package_by_path
#10493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As [here](https://linear.app/vercel/issue/TURBO-4724/expose-package-path-in-turborepository). Depending on the call-pattern that we want to support, it might be worthwhile to introduce a cache for ancestor-paths so that subsequent calls only need to traverse-up to a first-common-ancestor.
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Contributor
Author
|
AFAICT that deployment failure is unrelated to this code, though I don't know for sure. |
chris-olszewski
suggested changes
May 20, 2025
Contributor
chris-olszewski
left a comment
There was a problem hiding this comment.
Only concerns are around beefing up the tests.
| // every ancestor. | ||
| #[napi] | ||
| pub async fn find_package_by_path(&self, path: String) -> Result<Package, Error> { | ||
| let package_mapper = DefaultPackageChangeMapper::new(&self.graph); |
Contributor
There was a problem hiding this comment.
This is something that I should've given you a code pointer on. This is the structure we use to determine which files affect which packages. We can use it raw here to do the same purpose of mapping files to packages.
Happy to chat a bit more about this!
| match package_mapper.detect_package(&anchored_path) { | ||
| turborepo_repository::change_mapper::PackageMapping::All( | ||
| _all_package_change_reason, | ||
| ) => Err(Error::from_reason("file belongs to many packages")), |
Contributor
There was a problem hiding this comment.
An alternative here would be to possibly return the root package or return that the file change is considered "global".
| const workspace = await Workspace.find(MONOREPO_PATH); | ||
|
|
||
| for (const [filePath, result] of [ | ||
| ["apps/app/src/util/useful-file.ts", "app-a"], |
Contributor
There was a problem hiding this comment.
We should have some tests for root files e.g. a root tsconfig.json, pnpm-lock.yaml, pnpm-workspace.yaml
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
chris-olszewski
approved these changes
May 20, 2025
chris-olszewski
added a commit
that referenced
this pull request
May 20, 2025
### Description Bump version to release #10493 ### Testing Instructions 👀
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As raised here.
Depending on the call-pattern that we want to support, it might be worthwhile to introduce a cache for ancestor-paths so that subsequent calls only need to traverse-up to a first-common-ancestor.
Testing Instructions
pnpm build && pnpm testwithinpackages/turbo-repositorypasses.Note
I'm very much a Rust newbie, so please don't hold back on stylistic nits or comments - I have no strong opinions on "correct" Rust!