这是indexloc提供的服务,不要输入任何密码
Skip to content

docs: update managing-dependencies.mdx #10474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

Conversation

hijuliancode
Copy link
Contributor

Description

Hey,

In the "Best practices for dependency installation" section, the example command should be updated to align with the "Getting started" tutorial, where the default setup installs the docs/ and web/ apps.

Right now, it references @repo/web, but that package doesn't exist, what we actually have is @repo/ui.

The correct command should be:

pnpm install jest --save-dev --recursive --filter=web --filter=@repo/ui --filter=docs
Screenshot 2025-05-12 at 10 17 52

Instead of:

pnpm install jest --save-dev --recursive --filter=web --filter=@repo/ui --filter=@repo/web
Screenshot 2025-05-12 at 10 18 22 Screenshot 2025-05-12 at 10 19 11

Testing Instructions

(I'm reading the Turborepo docs and testing)

  1. Follow the Getting Started Tutorial
  2. Go to [Best practices for dependency installation](https://turborepo.com/docs/crafting-your-repository/managing-dependencies#best-practices-for-dependency-installation)
  3. Try to run:
pnpm install jest --save-dev --recursive --filter=web --filter=@repo/ui --filter=@repo/web
Screenshot 2025-05-12 at 10 20 50

Hey,

In the "Best practices for dependency installation" section, the example command should be updated to align with the "Getting started" tutorial, where the default setup installs the docs/ and web/ apps.

Right now, it references @repo/web, but that package doesn't exist, what we actually have is @repo/ui.

The correct command should be:
```
pnpm install jest --save-dev --recursive --filter=web --filter=@repo/ui --filter=docs
```

Instead of:
```
pnpm install jest --save-dev --recursive --filter=web --filter=@repo/ui --filter=@repo/web
```
@hijuliancode hijuliancode requested review from anthonyshew and a team as code owners May 12, 2025 15:23
@turbo-orchestrator turbo-orchestrator bot added area: docs Improvements or additions to documentation needs: triage New issues get this label. Remove it after triage labels May 12, 2025
Copy link

vercel bot commented May 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 3:25pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 3:25pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 3:25pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 3:25pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 3:25pm

Copy link

vercel bot commented May 12, 2025

@hijuliancode is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@anthonyshew anthonyshew merged commit 07cb01a into vercel:main May 12, 2025
28 of 34 checks passed
@anthonyshew anthonyshew changed the title docs: Update managing-dependencies.mdx docs: update managing-dependencies.mdx May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Improvements or additions to documentation needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants