这是indexloc提供的服务，不要输入任何密码
Skip to content

feat: hot-reloading for no-undeclared-env-vars ESLint rule #10468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 14, 2025
Merged

feat: hot-reloading for no-undeclared-env-vars ESLint rule #10468

merged 8 commits into from
May 14, 2025

Conversation

@anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented May 11, 2025 •
edited
Loading

Description

Fixes #10140 so that updating the env key in turbo.json is reflected in ESLint in your editor.

Testing Instructions

TODO

@anthonyshew anthonyshew requested a review from a team as a code owner May 11, 2025 20:10
@turbo-orchestrator turbo-orchestrator bot added the pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo label May 11, 2025
@vercel
Copy link
Contributor

vercel bot commented May 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 5:03am
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 5:03am
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 5:03am
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 5:03am
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 5:03am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 5:03am
examples-svelte-web ❌ Failed (Inspect) May 12, 2025 5:03am
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 5:03am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 5:03am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
turbo-site ⬜️ Skipped (Inspect) May 12, 2025 5:03am

@anthonyshew anthonyshew changed the title feat: hot-reloading for no-undeclared-env-vars ESLint rule fix: hot-reloading for no-undeclared-env-vars ESLint rule May 11, 2025
@anthonyshew anthonyshew requested review from chris-olszewski and removed request for dimitropoulos May 11, 2025 20:31
@anthonyshew anthonyshew changed the title fix: hot-reloading for no-undeclared-env-vars ESLint rule feat: hot-reloading for no-undeclared-env-vars ESLint rule May 11, 2025
@anthonyshew anthonyshew merged commit 12988d1 into main May 14, 2025
43 of 44 checks passed
@anthonyshew anthonyshew deleted the shew/e9f3f branch May 14, 2025 13:40
This was referenced May 15, 2025
Merged
Merged
@anthonyshew anthonyshew mentioned this pull request May 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

1 more reviewer

@chris-olszewski chris-olszewski chris-olszewski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

eslint-plugin-turbo does not pick up env changes is turbo.json when using shared eslint-config

3 participants

@anthonyshew @chris-olszewski