这是indexloc提供的服务，不要输入任何密码
Skip to content

Document 'inputs', fix up some docs consistency issues #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 13, 2022
Merged

Document 'inputs', fix up some docs consistency issues #1046

merged 5 commits into from
Apr 13, 2022

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Apr 13, 2022

No description provided.

@vercel
Copy link

vercel bot commented Apr 13, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Deployment Preview Updated
turbo-site ✅ Deployed View Apr 13, 2022 at 10:04PM (UTC)

@gsoltis gsoltis mentioned this pull request Apr 13, 2022
Merged
3 tasks
@ObliviousHarmony
Copy link
Contributor

This is good @gsoltis. It probably also makes sense to update docs/pages/docs/features/caching.mdx since it includes information about invalidation and hashing.

jaredpalmer
jaredpalmer suggested changes Apr 13, 2022
View reviewed changes
jaredpalmer
jaredpalmer suggested changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@jaredpalmer jaredpalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we show off a more restricted default inputs for test task that limit to src/**/.ts?x and test/**/*.test.ts?x or something? I get worried suggesting double stars in the package base

jaredpalmer
jaredpalmer approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@jaredpalmer jaredpalmer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to read this again tomorrow. I think we should discuss when we want to show off restricting inputs in the docs, but let's merge

@kodiakhq kodiakhq bot merged commit d5ebb9f into main Apr 13, 2022
@gsoltis gsoltis deleted the gsoltis/input_docs branch April 13, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpalmer jaredpalmer jaredpalmer approved these changes

@gaspar09 gaspar09 Awaiting requested review from gaspar09

@nathanhammond nathanhammond Awaiting requested review from nathanhammond

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsoltis @ObliviousHarmony @jaredpalmer