这是indexloc提供的服务,不要输入任何密码
Skip to content

feat: pnpm catalogs support #10452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 8, 2025
Merged

feat: pnpm catalogs support #10452

merged 18 commits into from
May 8, 2025

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented May 7, 2025

Description

Support for pnpm catalogs.

Testing Instructions

  • Wrote up some tests
  • Manually test turbo prune in dogfooding repos using default catalog
  • Manually test turbo prune in dogfooding repos using multiple catalogs

Copy link

vercel bot commented May 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:56pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:56pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:56pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:56pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:56pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:56pm
examples-svelte-web ❌ Failed (Inspect) May 8, 2025 1:56pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:56pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:56pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:56pm

@anthonyshew anthonyshew changed the title feat: pnpm catalogs feat: pnpm catalogs support May 7, 2025
@anthonyshew
Copy link
Contributor Author

anthonyshew commented May 7, 2025

Sitrep: This is working unless I use react-dom as the dependency in the catalog?

EDIT: Fixed! It was peer dependencies.

@anthonyshew anthonyshew marked this pull request as ready for review May 7, 2025 15:21
@anthonyshew anthonyshew requested a review from a team as a code owner May 7, 2025 15:21
@anthonyshew anthonyshew requested review from chris-olszewski and removed request for tknickman and dimitropoulos May 7, 2025 15:48
@anthonyshew anthonyshew linked an issue May 7, 2025 that may be closed by this pull request
1 task
Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need to sort out the peer deps better, but overall I think this is a really promising start.

@anthonyshew
Copy link
Contributor Author

@chris-olszewski, ready for your next look. I started getting stuck and did some AI generation, particularly in dd15ebd, so let me know if that's sus.

@anthonyshew anthonyshew enabled auto-merge (squash) May 8, 2025 14:03
@anthonyshew anthonyshew merged commit 72344ba into main May 8, 2025
39 of 40 checks passed
@anthonyshew anthonyshew deleted the shew/847c0 branch May 8, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants