feat: conditional update notifier message using package manager #10436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
approved these changes
May 5, 2025
| // TODO: make this package manager aware | ||
| let update_cmd = style("npx @turbo/codemod@latest update").cyan().bold(); | ||
|
|
||
| let update_cmd = match package_manager { |
Contributor
There was a problem hiding this comment.
Not blocking, but this will have to be undone down the road. Adding a package_manager.exec_command() would be preferred to avoid doing an explicit iteration over all supported package managers.
e.g.
fn exec_command(&self) -> &str {
match self {
PackageManager::Npm => "npx",
PackageManager::Yarn | PackageManager::Berry => "yarn dlx",
PackageManager::Pnpm | PackageManager::Pnpm6 | PackageManager::Pnpm9 => "pnpm dlx"
PackageManager::Bun =>"bunx",
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small bit of polish to make our update notifier be package manager aware. Defaults to npm.
Testing Instructions
Manually tested in a Bun repo.