fix: package scoping fails when workspace glob has leading ./ #10408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>
Contributor
|
Closing because it needs be restarted with a better prompt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8599
When workspace globs are defined with a leading
./in package.json (e.g.,"./packages/*"), Automatic Package Scoping doesn't work correctly. This PR fixes the issue by normalizing paths with leading./in theWorkspaceGlobs::newmethod, ensuring that workspace globs with leading./match package paths correctly.Changes
WorkspaceGlobs::newto strip the leading./from workspace globs././#8599 to assert the correct behaviorVerification
./are correctly normalizedLink to Devin run: https://app.devin.ai/sessions/59eb1187a64149edac3bfc4bccef2bc3
Requested by: anthony.shew@vercel.com