fix: handle PathError gracefully in add_files_from_stdout #10407

devin-ai-integration · 2025-04-30T04:13:53Z

Description

This PR fixes an issue where crates/turborepo-scm/src/git.rs panics in GitHub Actions when using the --affected flag with paths containing special characters (particularly Cyrillic symbols).

The panic occurs in the add_files_from_stdout method where it unwraps the result of reanchor_path_from_git_root_to_turbo_root, which can fail with a PathError::NotParent error.

This PR modifies the code to handle these errors gracefully by skipping problematic paths and logging a warning instead of panicking.

Fixes #10403

Verification

Verified that the code compiles
Verified that existing tests pass

Link to Devin run: https://app.devin.ai/sessions/8bc1623f365c4c5fab3d83c6c1c7279f
Requested by: anthony.shew@vercel.com

Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

devin-ai-integration · 2025-04-30T04:13:58Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment and CI monitoring

vercel · 2025-04-30T04:13:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
examples-basic-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 1, 2025 3:57pm
examples-designsystem-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 1, 2025 3:57pm
examples-gatsby-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 1, 2025 3:57pm
examples-kitchensink-blog	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 1, 2025 3:57pm
examples-native-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 1, 2025 3:57pm
examples-nonmonorepo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 1, 2025 3:57pm
examples-svelte-web	❌ Failed (Inspect)			May 1, 2025 3:57pm
examples-tailwind-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 1, 2025 3:57pm
examples-vite-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 1, 2025 3:57pm
turbo-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 1, 2025 3:57pm

Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

crates/turborepo-scm/src/git.rs

chris-olszewski · 2025-04-30T12:15:06Z

crates/turborepo-scm/src/git.rs

        turbo_root: &AbsoluteSystemPath,
        stdout: Vec<u8>,
    ) {
        let stdout = String::from_utf8(stdout).unwrap();


This can still panic if there's a non-UTF8 path in the output.

chris-olszewski · 2025-04-30T12:27:52Z

crates/turborepo-scm/src/git.rs

+                Ok(anchored_to_turbo_root_file_path) => {
+                    files.insert(anchored_to_turbo_root_file_path);
+                }
+                Err(err) => {


Bubble up this error so it reaches the caller and they can decide what to do with it. In our case when this error is eventually returned in change_detector.rs we should catch it and behave as if every package changed since we cannot identify which exact packages changed. The warning you added should be moved there with an updated message.

…hange_detector Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

…hange_detector Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

…ct success Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

chris-olszewski · 2025-05-01T15:23:39Z

crates/turborepo-lib/src/run/scope/change_detector.rs

+                    })
+                    .collect());
+            }
+            Err(ScmError::Path(err, _)) => {


Can you deduplicate the generation of "all packages changed due to error" logic?

chris-olszewski · 2025-05-01T15:24:34Z

crates/turborepo-lib/src/run/scope/change_detector.rs

+                    .map(|(name, _)| {
+                        (
+                            name.to_owned(),
+                            PackageInclusionReason::All(AllPackageChangeReason::GitRefNotFound {


Can you change this variant now that it is for many different git related failures instead of just the ref not being found?

chris-olszewski · 2025-05-01T15:25:48Z

crates/turborepo-scm/src/git.rs

-    ) {
-        let stdout = String::from_utf8(stdout).unwrap();
+    ) -> Result<(), Error> {
+        let stdout = String::from_utf8_lossy(&stdout);


I do not want a lossy conversion as this will cause silent failures upstream. Please report up any non-UTF8 output as an error.

chris-olszewski · 2025-05-01T15:29:48Z

crates/turborepo-scm/src/git.rs

-                .reanchor_path_from_git_root_to_turbo_root(turbo_root, path)
-                .unwrap();
-            files.insert(anchored_to_turbo_root_file_path);
+            match RelativeUnixPath::new(line) {


We do not need to handle the error case for RelativeUnixPath::new failing. We can just unwrap() it as it will only fail if given a path that starts with / and git will not output absolute paths for the command we're parsing.

Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

anthonyshew · 2025-05-02T18:18:37Z

Closing this one. Sorry, Devin, I think I prompted you poorly. Maybe some other time.

biru-codeastromer · 2025-11-12T06:05:20Z

Hey @anthonyshew I have tried an approach to solve this .Let me know what you think of the new PR in regards to how it handles it.. new PR
Thanks !

fix: handle PathError gracefully in add_files_from_stdout

61b7dd7

Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

devin-ai-integration bot requested a review from a team as a code owner April 30, 2025 04:13

devin-ai-integration bot requested review from dimitropoulos and tknickman April 30, 2025 04:13

turbo-orchestrator bot added the needs: triage label Apr 30, 2025

vercel bot deployed to Preview – examples-nonmonorepo April 30, 2025 04:14 View deployment

fix: format warn! macro according to Rust style guidelines

91441b5

Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

vercel bot deployed to Preview – examples-gatsby-web April 30, 2025 04:16 View deployment

vercel bot deployed to Preview – examples-basic-web April 30, 2025 04:16 View deployment

vercel bot deployed to Preview – examples-nonmonorepo April 30, 2025 04:16 View deployment

test: add test coverage for handling unancorable paths

30bb433

Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

vercel bot deployed to Preview – examples-gatsby-web April 30, 2025 04:27 View deployment

vercel bot deployed to Preview – examples-nonmonorepo April 30, 2025 04:27 View deployment

vercel bot deployed to Preview – examples-basic-web April 30, 2025 04:27 View deployment

style: fix formatting in test code

29eed78

Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

vercel bot deployed to Preview – examples-basic-web April 30, 2025 04:30 View deployment

vercel bot deployed to Preview – examples-gatsby-web April 30, 2025 04:30 View deployment

vercel bot deployed to Preview – examples-nonmonorepo April 30, 2025 04:30 View deployment

anthonyshew reviewed Apr 30, 2025

View reviewed changes

crates/turborepo-scm/src/git.rs Show resolved Hide resolved

Update crates/turborepo-scm/src/git.rs

656c20f

chris-olszewski suggested changes Apr 30, 2025

View reviewed changes

devin-ai-integration bot and others added 7 commits April 30, 2025 12:34

fix: bubble up errors from add_files_from_stdout and handle them in c…

517a5d3

…hange_detector Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

style: fix formatting issues to pass Rust lints

39bb312

Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

fix: use GitRefNotFound instead of non-existent Other variant

2bbcf47

Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

fix: handle path errors with warnings instead of bubbling up errors

0b6951e

Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

fix: bubble up errors from add_files_from_stdout and handle them in c…

aa8f5e9

…hange_detector Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

fix: return error directly instead of wrapping in Error::Path

b91af4f

Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

style: fix formatting issues to pass Rust lints

7970096

Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

devin-ai-integration bot and others added 3 commits April 30, 2025 14:15

fix: log warnings for problematic paths instead of returning errors

9e52ecf

Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

test: update test_add_files_from_stdout_with_unancorable_path to expe…

91bf779

…ct success Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

fix: format warning macro to pass Rust lints

225d993

Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

chris-olszewski suggested changes May 1, 2025

View reviewed changes

devin-ai-integration bot and others added 5 commits May 1, 2025 15:34

fix: address PR feedback from chris-olszewski

2bc0866

Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

style: format warning macro to match rustfmt style

7762841

Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

fix: fix type mismatches in change_detector.rs

c5bed4e

Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

fix: remove ? operator to fix mismatched types in change_detector.rs

6d59b8c

Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

test: update test to expect success instead of error

a085d64

Co-Authored-By: anthony.shew@vercel.com <anthonyshew@gmail.com>

anthonyshew closed this May 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: handle PathError gracefully in add_files_from_stdout #10407

fix: handle PathError gracefully in add_files_from_stdout #10407

devin-ai-integration bot commented Apr 30, 2025

Uh oh!

devin-ai-integration bot commented Apr 30, 2025

Uh oh!

vercel bot commented Apr 30, 2025 •

edited

Loading

Uh oh!

Uh oh!

chris-olszewski Apr 30, 2025

Uh oh!

chris-olszewski Apr 30, 2025

Uh oh!

chris-olszewski May 1, 2025

Uh oh!

chris-olszewski May 1, 2025

Uh oh!

chris-olszewski May 1, 2025

Uh oh!

chris-olszewski May 1, 2025

Uh oh!

anthonyshew commented May 2, 2025

Uh oh!

biru-codeastromer commented Nov 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix: handle PathError gracefully in add_files_from_stdout #10407

fix: handle PathError gracefully in add_files_from_stdout #10407

Conversation

devin-ai-integration bot commented Apr 30, 2025

Description

Verification

Uh oh!

devin-ai-integration bot commented Apr 30, 2025

🤖 Devin AI Engineer

Uh oh!

vercel bot commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

chris-olszewski Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

chris-olszewski Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

chris-olszewski May 1, 2025

Choose a reason for hiding this comment

Uh oh!

chris-olszewski May 1, 2025

Choose a reason for hiding this comment

Uh oh!

chris-olszewski May 1, 2025

Choose a reason for hiding this comment

Uh oh!

chris-olszewski May 1, 2025

Choose a reason for hiding this comment

Uh oh!

anthonyshew commented May 2, 2025

Uh oh!

biru-codeastromer commented Nov 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vercel bot commented Apr 30, 2025 •

edited

Loading