这是indexloc提供的服务,不要输入任何密码
Skip to content

Resolve symlinks when determining cwd #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2022
Merged

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented May 16, 2022

Fixes #920

Based on yarn, berry, npm, and pnpm all resolving symlinks in getting the path to cwd, turbo should too.

@vercel
Copy link

vercel bot commented May 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview May 17, 2022 at 6:39PM (UTC)

@gsoltis gsoltis marked this pull request as ready for review May 16, 2022 17:27
Copy link
Contributor

@jaredpalmer jaredpalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, lets just add comments so we / contributors don't forget about why we are doing this

@jaredpalmer jaredpalmer merged commit 2063cbc into main May 17, 2022
@jaredpalmer jaredpalmer deleted the gsoltis/resolve_symlinks branch May 17, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turbo can't find any packages in the defined workspaces if current dir is a symbolic link
2 participants