Inputs that reference files outside of package using path traversal leaves turbo files around on disk. #1253
Description
What version of Turborepo are you using?
1.2.9
What package manager are you using / does the bug impact?
Yarn v1
What operating system are you using?
Mac
Describe the Bug
From what I read in the discussions, supplying inputs that reference files outside the package (e.g root files) should be supported. This works, but whenever running across all packages it leaves metafiles around in the repository like such..
drwxr-xr-x - sachin.patel 17 May 17:02 fd60abb4eb1c6984/
.rw-r--r-- 43 sachin.patel 17 May 17:01 fd60abb4eb1c6984-meta.json
drwxr-xr-x - sachin.patel 17 May 17:02 fd1064074d100bce/
.rw-r--r-- 43 sachin.patel 17 May 16:49 fd1064074d100bce-meta.json
drwxr-xr-x - sachin.patel 17 May 17:02 fdbc833fa99980e4/
.rw-r--r-- 43 sachin.patel 17 May 16:57 fdbc833fa99980e4-meta.json
drwxr-xr-x - sachin.patel 17 May 17:02 fdc0149ad58992ae/
.rw-r--r-- 43 sachin.patel 17 May 16:36 fdc0149ad58992ae-meta.json
drwxr-xr-x - sachin.patel 17 May 17:02 fe2c3f60d2dcfa93/
.rw-r--r-- 43 sachin.patel 17 May 16:50 fe2c3f60d2dcfa93-meta.json
drwxr-xr-x - sachin.patel 17 May 17:02 fe3b84e3804d748a/
.rw-r--r-- 45 sachin.patel 17 May 14:50 fe3b84e3804d748a-meta.json
drwxr-xr-x - sachin.patel 17 May 17:02 fe7ee6a0db9a48b2/
.rw-r--r-- 44 sachin.patel 17 May 16:57 fe7ee6a0db9a48b2-meta.json
drwxr-xr-x - sachin.patel 17 May 17:02 fec729c28e97af10/
.rw-r--r-- 43 sachin.patel 17 May 16:56 fec729c28e97af10-meta.json
drwxr-xr-x - sachin.patel 17 May 17:02 fed47b766e838b57/
.rw-r--r-- 43 sachin.patel 17 May 16:57 fed47b766e838b57-meta.json
drwxr-xr-x - sachin.patel 17 May 17:02 fef738e303246bb2/
.rw-r--r-- 43 sachin.patel 17 May 17:01 fef738e303246bb2-meta.json
drwxr-xr-x - sachin.patel 17 May 17:02 ff777e932ee98fbc/
.rw-r--r-- 44 sachin.patel 17 May 13:34 ff777e932ee98fbc-meta.json
drwxr-xr-x - sachin.patel 17 May 17:02 ff6663bd6e206e38/
.rw-r--r-- 43 sachin.patel 17 May 16:50 ff6663bd6e206e38-meta.json
Expected Behavior
There should not be any lingering files after a task is executed when inputs refer to files outside of the package.
To Reproduce
This task for prettier highlights the issue.
"format": {
"inputs": [
"*.js",
"*.jsx",
"*.ts",
"*.tsx",
"*.json",
"*.md",
"**/*.js",
"**/*.jsx",
"**/*.ts",
"**/*.tsx",
"**/*.json",
"**/*.md",
"../../.prettierrc.js"
],
"outputs": []
},
Run turbo run format and the task will complete but will leave dangling files in the repository.
If you remove the last entry "../../.prettierrc.js" this issue does not happen.