-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed
Labels
kind: bugSomething isn't workingSomething isn't working
Description
What version of Turborepo are you using?
1.1.2
What package manager are you using / does the bug impact?
Yarn v1
What operating system are you using?
Windows
Describe the Bug
./package.json
{
"scripts": {
"build:docker": "turbo run build:docker --parallel"
}
}./turbo.json
{
"pipeline": {
"build:docker": {
"outputs": []
}
}
}./apps/my-app/api/package.json
{
"scripts": {
"build:docker": "cd ../../../ && docker build . -f infrastructure/docker/Dockerfile -t my-app-api:latest"
}
}folder structure
monorepo/
package.json
infrastructure/
docker/
Dockerfile
apps/
my-app/
api/
package.jsonWhen re-running yarn build:docker getting cache miss.
Renaming npm scripts from build:docker to build-docker solved an issue.
Expected Behavior
Turbo should support any npm script naming convention.
Consider replacing "non friendly" characters in npm script name with a defined placeholder char:
(underscore or dual-underscore for example)
build:docker=>build__dockerbuild#docker=>build__docker
Or use npm script name hash for log files name.
BTW # in script name makes Turbo panic
To Reproduce
- Name your package.json scripts using
:or#characters. - Expect
- for
:: miss formed log file - for
#: panic
- for
Metadata
Metadata
Assignees
Labels
kind: bugSomething isn't workingSomething isn't working