[turborepo] turbo gen. Add support for Github enterprise templates #7463
Replies: 10 comments 4 replies
-
|
Hello @anthonyshew, I noticed that my comment was marked as spam, and I was wondering if you could clarify what might have caused this. |
Beta Was this translation helpful? Give feedback.
-
|
We try to have folks not comment with "+1" type comments as they send notifications to anyone trying to keep up with the discussion without providing substantive information. If you'd like to "+1" something, please use the upvote button or a 👍 reaction. Sorry if "marked as spam" feels too punitive. The options GitHub shows when marking something for hiding don't really have a great option for conveying "please don't add +1 comments". "Spam" is probably too heavy-handed of a description, and folks don't generally have ill intent when +1'ing - but it's the best we have! |
Beta Was this translation helpful? Give feedback.
-
|
Mentioned this here, as well, albeit with less words. 😁 |
Beta Was this translation helpful? Give feedback.
-
|
Thank you so much for taking the time to explain this in detail. I completely understand your explanation and truly agree with it. |
Beta Was this translation helpful? Give feedback.
This comment was marked as spam.
This comment was marked as spam.
-
|
Please do not add "+1" comments. If you'd like to express your interest, please upvote the top-level. |
Beta Was this translation helpful? Give feedback.
-
|
No worries at all - awesome! Thanks for confirming. |
Beta Was this translation helpful? Give feedback.
-
|
Sorry for the misunderstanding. That url does work and trigger a download of the repo. |
Beta Was this translation helpful? Give feedback.
-
|
Hey @NickHackford thanks! No need to test with Can you try just going to: |
Beta Was this translation helpful? Give feedback.
-
|
Hey there. I was out on leave but I'm back now. Sorry for the delay. I ran the command with the proper host name and it fails when it gets to the part where it starts copying with the error. The turbo version was 1.10.12. I'm not sure if it's failing somewhere else now if I'm doing something wrong. |
Beta Was this translation helpful? Give feedback.
-
|
@NickHackford could you verify that the following works for Github Ent? (I don't have access to an Ent instance myself, so I just want to double check). Try and visit the following url and ensure it kicks off a download as expected: |
Beta Was this translation helpful? Give feedback.
-
|
Hey @NickHackford, sorry for the delay here, we should be able to make this work, but it is slightly more involved than the line you pointed out! We have the check that you found in place because all of our utilities to actually download the files we need are specific to Github. You can check those out here: https://github.com/vercel/turbo/blob/main/packages/turbo-utils/src/examples.ts We could consider opening that check to enforce |
Beta Was this translation helpful? Give feedback.
-
|
Hey Chris. The url our github is hosted at is https://github.ourcompany.com and I cannot see the template unless I am logged into my enterprise github account. |
Beta Was this translation helpful? Give feedback.
-
|
Hi @NickHackford, could you provide an example URL of the enterprise repo you're trying to use (doesn't have to be exact)? Also, do you know if there's any authentication required to access the template? |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
What version of Turborepo are you using?
1.10.7
What package manager are you using / does the bug impact?
Yarn v2/v3 (node_modules linker only)
What operating system are you using?
Mac
Describe the Bug
When running the command
yarn turbo gen workspace --copyand a url pointing to our enterprise github, I get the error.There is line here that filters out any urls that don't match github.com but I'm not sure if there's more that needs to be changed in order for this to work. I tried changing it locally and testing it but I was struggling to run my local version since it is invoked by the binary through npx.
Expected Behavior
I would expect to be able to run turbo gen copy against our enterprise github urls.
To Reproduce
Run the command
yarn turbo gen workspace --copyin a repo with your own hosted github repo as the value for the copy flag.Reproduction Repo
No response
Beta Was this translation helpful? Give feedback.
All reactions