Why doesn't packages/ui have a .eslintrc.js file whereas apps/docs and apps/web do? And why do they need one?
#3381
-
|
In the default Turborepo configuration, three directories are set up to be linted:
module.exports = {
root: true,
// This tells ESLint to load the config from the package `eslint-config-custom`
extends: ["custom"],
settings: {
next: {
rootDir: ["apps/*/"],
},
},
};
module.exports = {
root: true,
extends: ["custom"],
};My question is: If the |
Beta Was this translation helpful? Give feedback.
Replies: 3 comments 9 replies
-
|
It's possible this is an oversight? cc @tknickman |
Beta Was this translation helpful? Give feedback.
-
|
Where's the part of the docs that explains that they are two ways of doing the same thing and that it's made that way to illustrate them? And I still don't understand what the difference is between them, which is something that the docs should explain too and that I don't think they do. What use cases would benefit from either? The explanation should be in the "Getting started" section, as that is the section that most concerns the setup of the starter template. |
Beta Was this translation helpful? Give feedback.
-
|
@albertothedev what you're saying makes sense, thanks for the attention to detail. |
Beta Was this translation helpful? Give feedback.
-
|
I have been painfully trying to understand the different ways to configure eslint in a monorepo. I follow @albertothedev comment, where it would be really helpful if those questions could be answered somehow. |
Beta Was this translation helpful? Give feedback.
-
|
@thedaviddias The comments on this PR I opened: #4172 give more information on the topic. You might find them helpful. |
Beta Was this translation helpful? Give feedback.
-
|
Awesome @albertothedev, I'm gonna take a look! Appreciate the answer. |
Beta Was this translation helpful? Give feedback.
-
|
Apologies for the confusion here @albertothedev. The way this is setup in the template is a little bit confusing and unnecessary. This is meant to demonstrate a situation when, to take one example, you have a monorepo comprised of all react apps / packages, and have added a single different application (Next.js, Vue etc). You may want that single eslint config at root that applies to everything, but then override an individual app or package with its own config that has more specific plugins etc. But in its current form, this is a bit confusing - PR's welcome! |
Beta Was this translation helpful? Give feedback.
-
|
I have opened the RFC #3621 to discuss solutions to this issue. |
Beta Was this translation helpful? Give feedback.
Apologies for the confusion here @albertothedev. The way this is setup in the template is a little bit confusing and unnecessary. This is meant to demonstrate a situation when, to take one example, you have a monorepo comprised of all react apps / packages, and have added a single different application (Next.js, Vue etc). You may want that single eslint config at root that applies to everything, but then override an individual app or package with its own config that has more specific plugins etc.
But in its current form, this is a bit confusing - PR's welcome!