Disable "Remote cache is read-only, skipping upload" warning #10774
gmartenscb
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Goals
Non-goals
No response
Background
Currently we are using
turboto run tasks during our Pull Request inspections.We build a lot of packages, and test those within a local playground.
For all the packages, the cache is stored on a remote through an AWS Lambda Function URL.
However, for the "playground" this is unfortunately not possible due to Lambda's 6MB Request payload limit.
Therefore we have turned remote caching off for this particular step.
This is done through
--cache=local:rw,remote:r, which works as it should.However, we now always get a warning that remote caching is disabled for writing.
This unfortunately will make our step show up as orange, even though everything is working as expected.
It is not failing, it is not a blocking issue, but something that would be a nice improvement.
Proposal
The warning that is shown, is found here: https://github.com/vercel/turborepo/blame/0d7034ec5ab5855251ef5a49b132c34a95337d01/crates/turborepo-cache/src/multiplexer.rs#L117
Which is already nicely behind an
if-statement forshould_print_skipping_remote_put.However, that flag is currently always hardcoded to
true, here: https://github.com/vercel/turborepo/blame/0d7034ec5ab5855251ef5a49b132c34a95337d01/crates/turborepo-cache/src/multiplexer.rs#L67Ideally, this would not be hardcoded but configurable.
The implementation I want to leave up to you.
Either through a separate flag, which might be a bit overkill,
or perhaps based on the verbosity level, which is already available.
Beta Was this translation helpful? Give feedback.
All reactions