Omit null environment variables in vercel_deployment
#96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a vercel_deployment and passing a `null` environment variable results in a conversion error. ``` An unexpected error was encountered trying to build a value. This is always an error in the provider. Please report the following to the provider developer: Received null value, however the target type cannot handle null values. Use the corresponding `types` package type, a pointer type or a custom type that handles null values. Path: ["BAZ"] Target Type: string Suggested `types` Type: basetypes.StringValue Suggested Pointer Type: *string ``` We need to handle the case where the field value is `null`, which is currently omitted. Since the API only accepts string values for enviroment variables, the best solution is to simply omit sending `null` to the API altogether. Closes #95
adriancooney
reviewed
Jan 6, 2023
| @@ -109,7 +109,8 @@ func TestAcc_DeploymentWithEnvironment(t *testing.T) { | |||
| { | |||
| Config: testAccDeploymentConfig(projectSuffix, teamIDConfig(), `environment = { | |||
| FOO = "baz", | |||
| BAR = "qux" | |||
| BAR = "qux", | |||
| BAZ = null | |||
There was a problem hiding this comment.
Do we need to check that BAZ is not present on the output? I suppose this test would fail otherwise.
There was a problem hiding this comment.
The test failed before the changes b/c of the deserialization issue. It's a bit rubbish but the test helpers don't give a nice way to check for a null value on the output. I think just checking that it doesn't cause the provider to panic is as good as we can do (which is the purpose of this).
adriancooney
approved these changes
Jan 6, 2023
ecklf
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a vercel_deployment and passing a
nullenvironment variable results in a conversion error.We need to handle the case where the field value is
null, which is currently omitted.Since the API only accepts string values for enviroment variables, the best solution is to simply omit sending
nullto the API altogether.Closes #95