Upgrade to terraform framework v13 #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dglsparsons
commented
Sep 19, 2022
- V12 release notes
- V13 release notes
- [V12 release notes](https://github.com/hashicorp/terraform-plugin-framework/releases/tag/v0.12.0) - [V13 release notes](https://github.com/hashicorp/terraform-plugin-framework/releases/tag/v0.13.0)
6dd3daa to
f6c24cd
Compare
| @@ -105,10 +132,9 @@ At this time you cannot use a Vercel Project resource with in-line ` + "`environ | |||
| Sensitive: true, | |||
| }, | |||
| "id": { | |||
| Description: "The ID of the Environment Variable.", | |||
| Type: types.StringType, | |||
| PlanModifiers: tfsdk.AttributePlanModifiers{resource.UseStateForUnknown()}, | |||
There was a problem hiding this comment.
We don't need these modifiers anymore? :o
There was a problem hiding this comment.
It's actually incorrect here - the project resource doesn't bother doing an update on the environment variables, and instead just deletes any that do not match the state after, and adds new ones.
So we can't rely on stable IDs between updates for env variables.
kakadiadarpan
approved these changes
Sep 20, 2022
| } | ||
|
|
||
| func (d *aliasDataSource) Configure(ctx context.Context, req datasource.ConfigureRequest, resp *datasource.ConfigureResponse) { | ||
| // Prevent panic if the provider has not been configured. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.