Prevent project field coercion on creation #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Vercel API the following fields are coerced to null during project creation if they are falsy: * BuildCommand * DevCommand * InstallCommand * OutputDirectory * PublicSource This causes an issue when they are specified, but falsy, as the terraform configuration explicitly sets a value for them, but the Vercel API returns a different value. This causes an inconsistent plan error. We avoid this issue by choosing to use values from the terraform state, but only if they are _explicitly stated_ *and* they are _falsy_ values *and* the response value was Null. This is important as drift detection would fail to work if the value was always selected.
d9d94cd to
ab025ba
Compare
|
2 extra changes I'll make before this gets merged:
|
ecklf
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Vercel API the following fields are coerced to null during project creation
if they are falsy in the create-project request:
This causes an issue when they are specified, but falsy, as the
terraform configuration explicitly sets a value for them, but the Vercel
API returns a different value. This causes an inconsistent plan error.
We avoid this issue by choosing to use values from the terraform state,
but only if they are explicitly stated and they are falsy values
and the response value was Null. This is important as drift detection
would fail to work if the value was always selected.
Closes #56