Add UseStateForUnknown plan modifier to attributes that are stable when being updated
#44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when being updated When updating a resource with `Computed` attributes, these attributes will be set to `unknown` at plan time (as they could change). This means any dependent resources will be flagged as requiring deletion and recreation. However, for the vast majority of attributes within our Terraform provider, such as `ID` fields, these attributes _never_ change when a resource is updated. Instead, they only change when the resource is destroyed and created again. This is the exact behaviour of the `UseStateForUnknown` plan modifier.
ecklf
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating a resource with
Computedattributes, these attributeswill be set to
unknownat plan time (as they could change).This means any dependent resources will be flagged as requiring deletion
and recreation.
However, for the vast majority of attributes within our Terraform
provider, such as
IDfields, these attributes never change when aresource is updated. Instead, they only change when the resource is destroyed and
created again. This is the exact behaviour of the
UseStateForUnknownplan modifier.Closes #40