Fix saml property on team config resource #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is causing refresh plans to be non-empty, as it continually thinks the saml property is changing, even though it is not. The plan shows zero changes (daft TF!). Fix by removing the default, which conflicts when you have computed state + UseStateForUnknown.
e39b6d3 to
ffcc442
Compare
craigandrews
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing refresh plans to be non-empty, as it continually thinks
the saml property is changing, even though it is not. The plan shows
zero changes (daft TF!).
Fix by removing the default, which conflicts when you have computed
state + UseStateForUnknown.