Remove windows line-ending conversions #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was originally implemented to prevent spurious diffs when swapping the same repository between windows and unix systems. However, due to the lack of detection of binary files, such as png images, this can cause some files to be corrupted. Looking at the [file command behaviour](https://github.com/file/file/blob/f2a6e7cb7db9b5fd86100403df6b2f830c7f22ba/src/encoding.c#L151-L228) it seems like detecting binary/non-binary files is extremely non-trivial, and heuristic at best (meaning it could be wrong). In order to prevent hard to detect/analyse issues, I think it's best to just accept that some spurious changes can occur if swapping between systems.
kakadiadarpan
previously approved these changes
Aug 26, 2022
124af3b to
43a29ac
Compare
ecklf
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally implemented to prevent spurious diffs when
swapping the same repository between windows and unix systems.
However, due to the lack of detection of binary files, such as png
images, this can cause some files to be corrupted.
Looking at the file command behaviour
it seems like detecting binary/non-binary files is extremely
non-trivial, and heuristic at best (meaning it could be wrong).
In order to prevent hard to detect/analyse issues, I think it's best to
just accept that some spurious changes can occur if swapping between
systems.
This relates to #50 and #53
Closes #61