Implement vercel_edge_config_item #196

LukeSheard · 2024-07-29T18:03:41Z

Add a resource for managing individual edge_config_item resources. Each resource represents an individual (key, value) pair for an Edge Config.

resource "vercel_edge_config" "example" {
  name = "example"
}

resource "vercel_project" "example" {
  name = "edge-config-example"
}

resource "vercel_edge_config_item" "example": {
  edge_config_id = vercel_edge_config.example.id
  key            = "key"
  value          = "value"
}

I've essentially used the upsert API from the documentation for managing items.

vercel/resource_edge_config_item.go

…ace to avoid writing an update API.

dglsparsons · 2024-07-30T10:36:48Z

vercel/resource_edge_config_item.go

+type edgeConfigItemResource struct {
+	client *client.Client
+}


This needs wiring up in the provider.go file. We could also do with tests, and given there's a fairly sane Read method I think we could add a data source too.

I've wired this up and added an equivalent data source.

dglsparsons · 2024-10-10T09:40:55Z

Hi @LukeSheard, is there a reason you closed this? Apologies for not getting back to you sooner on this too - I've been off on Paternity leave for a while. I can take over this PR though, and add support for this.

LukeSheard · 2024-10-10T10:15:20Z

@dglsparsons I think it was by accident to be honest!

LukeSheard · 2024-10-10T11:06:48Z

@dglsparsons What is missing at this point to get this merged? 😄

dglsparsons · 2024-10-10T11:09:45Z

Just tests.

dglsparsons · 2024-10-10T16:10:19Z

FYI @LukeSheard i'll raise a PR in the morning with tests added. Code is complete and it seems to work like a charm with a couple of minor fixes. 🙌

LukeSheard · 2024-10-10T16:26:52Z

@dglsparsons Thanks so much, I haven't had a chance to test the provider locally directly to validate that it works properly. Very appreciative of your support 🙇

dglsparsons · 2024-10-11T09:44:08Z

Closed in favour of #210

Implement vercel_edge_config_item

5290b0f

LukeSheard requested a review from dglsparsons as a code owner July 29, 2024 18:03

LukeSheard mentioned this pull request Jul 29, 2024

Add support for Edge Config #148

Closed