Add OPTIONS Allowlist support to vercel terraform provider #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dglsparsons
reviewed
May 22, 2024
Comment on lines
+230
to
+234
| ElementType: types.ObjectType{ | ||
| AttrTypes: map[string]attr.Type{ | ||
| "value": types.StringType, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
How come it's a list of objects, not just a list of strings?
There was a problem hiding this comment.
Making it flexible for the future, leaves room for configurations of the paths. For example, Trusted IPs has notes. For this feature I can see supporting regex, or requiring specific headers on the request etc.
There was a problem hiding this comment.
Gotcha. Well, this LGTM 🙏
There was a problem hiding this comment.
To make sure I fully answered your question, this structure is a 1-1 reflection of the db / api structure
dglsparsons
previously approved these changes
May 22, 2024
dglsparsons
approved these changes
May 22, 2024
renovate bot
referenced
this pull request
in inabagumi/shinju-date
May 22, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [vercel](https://registry.terraform.io/providers/vercel/vercel) ([source](https://togithub.com/vercel/terraform-provider-vercel)) | required_provider | minor | `1.10.1` -> `1.11.0` | --- ### Release Notes <details> <summary>vercel/terraform-provider-vercel (vercel)</summary> ### [`v1.11.0`](https://togithub.com/vercel/terraform-provider-vercel/releases/tag/v1.11.0) [Compare Source](https://togithub.com/vercel/terraform-provider-vercel/compare/v1.10.1...v1.11.0) #### What's Changed - Add OPTIONS Allowlist support to vercel terraform provider by [@​kitfoster](https://togithub.com/kitfoster) in [https://github.com/vercel/terraform-provider-vercel/pull/186](https://togithub.com/vercel/terraform-provider-vercel/pull/186) **Full Changelog**: vercel/terraform-provider-vercel@v1.10.1...v1.11.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/inabagumi/shinju-date). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Terraform support for the new OPTIONS Allowlist feature
👉 docs
👉 changelog