Add support for Deploy Hooks #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy Hooks are available underneath the `git_repostiory` section of a `vercel_project`. These generate a URL that can be used to trigger new deployment of a specific `ref`. Existing on the `vercel_project` resource under `git_repository` is the only place that seems to make sense, as linking/unlinking a git repository causes all deploy hooks to require recreation, so they cannot exist as a separate resource. Closes #104
ecklf
reviewed
Apr 24, 2024
| @@ -37,12 +37,12 @@ func testAccProjectEnvironmentVariablesDoNotExist(n, teamID string) resource.Tes | |||
| return fmt.Errorf("no ID is set") | |||
| } | |||
|
|
|||
| project, err := testClient().GetProject(context.TODO(), rs.Primary.ID, teamID, true) | |||
| envs, err := testClient().GetEnvironmentVariables(context.TODO(), rs.Primary.ID, teamID) | |||
There was a problem hiding this comment.
Just curious, what does context.TODO do?
ecklf
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy Hooks are available underneath the
git_repostiorysection of avercel_project.These generate a URL that can be used to trigger new deployment of a
specific
ref.Existing on the
vercel_projectresource undergit_repositoryisthe only place that seems to make sense, as linking/unlinking a
git repository causes all deploy hooks to require recreation, so
they cannot exist as a separate resource.
Closes #104