team_id should not be computed #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Team IDs are optionally set on a per-resource basis. However, when omitted, they should not be set as 'computed', because they can never be anything other than Null/Unknown. Computed makes them show as unknown, expecting the value to later be set. This causes a weird churn when creating resources under a personal Vercel account. Closes #136
ecklf
approved these changes
Oct 24, 2023
dglsparsons
added a commit
that referenced
this pull request
Oct 24, 2023
This reverts commit 42e9671.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Team IDs are optionally set on a per-resource basis. However, when omitted, they should not be set as 'computed', because they can never be anything other than Null/Unknown. Computed makes them show as unknown, expecting the value to later be set.
This causes a weird churn when creating resources under a personal Vercel account.
Closes #136