Fix issues with removing git_repository from a project #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
050d3e8 to
7b63723
Compare
At the moment, this should force recreation of the project, as we don't support updating or removing the linked repository. See issue #105 for info on this. However, there is a bug insofar as we don't explicitly flag this as requiring the project to be replaced. This creates an inconsistent plan.
7b63723 to
3973646
Compare
ecklf
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, this should force recreation of the project, as we don't support updating or removing the linked repository.
See issue #105 for info on this.
However, there is a bug insofar as we don't explicitly flag this as requiring the project to be replaced. This creates an inconsistent plan.
Closes #133